karma-runner / karma-dojo

A Karma plugin. Adapter for Dojo Toolkit.
MIT License
7 stars 10 forks source link

Chain dependency downloading to force reliable execution order #18

Open divido opened 7 years ago

divido commented 7 years ago

Dojo's require downloads all dependencies concurrently, and executes each as part of finalizing it. This can cause the test specs to be processed in a different order. If using a test framework that supports test ordering (like jasmine), it needs the specs to come in the same order. Otherwise, the ordering will produce different ordering, even for the same random seed.

This snagged me trying to track down a unit test failure that was order dependent. To reproduce the problem, you need to create a bunch of spec files, preferably of differing sizes, so that there's a good chance they will finish downloading in a different order than they started.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


divido commented 7 years ago

I signed the Google CLA.

googlebot commented 7 years ago

CLAs look good, thanks!