search

karma-runner / karma-dojo

A Karma plugin. Adapter for Dojo Toolkit.
MIT License
7 stars 10 forks source link

Dojo Dependency #7

Open jtmille3 opened 9 years ago

jtmille3 commented 9 years ago

If you are interested I forked your repo and made dojo a peer dependency so the user can choose which version of dojo they run against. It would be ideal to merge back into this repo as I am sure that is what people are most familiar with. Otherwise I'll continue to maintain this in my repo. Thanks for the plugin. Cheers.

tomwayson commented 9 years ago

@jtmille3

I finally got a chance to pull this down and test it. I can confirm that it works, though most of the changes here are not suitable for PR back to this repository as they are related to being able to publish your own copy of the repo.

I made a few comments on the code, and also, I believe you should also be able to (and should) delete this file from your repo:

https://github.com/jtmille3/karma-dojo/blob/master/lib/dojo.js

Would you be willing to update this PR, or open a new one that only has the changes needed for this repo to require Dojo as a dependency?

@garcimouche, do you have thoughts on require Dojo as a dependency? I think it's a great idea, and that @jtmille3 is on the right path here, just need to make a PR that doesn't include all the changes needed for him to publish his own package.