search

karma-runner / karma-edge-launcher

A Karma plugin. Launcher for Microsoft Edge.
MIT License
21 stars 7 forks source link

Fix #4 #5

Closed Itee closed 5 years ago

Itee commented 5 years ago

Hi there,

This PR will fix #4 but make some changes (non breaking i think) about the logic.

It use two powershell scripts instead of the edge-launcher package wrapped into start and exit handlers to start and stop gracefully edge process.

I improved the units tests too and update them accordingly to the new features.

Hope this help. Expecting your review and have a nice day !

zzo commented 5 years ago

please fix the PR to match our conventions thanks!

Itee commented 5 years ago

Mmmh sorry for that, i wasn't aware of it. I will update the PR.

I got some trouble about travis builds... due to the environement of build. How could i tell to travis that powershell is a pre-requis ?

Itee commented 5 years ago

I will create a new PR with updated commit messages. So i close this one.

nickserv commented 5 years ago

I haven't tried Travis on Windows, it might be easier to get it working on AppVeyor: https://ci.appveyor.com/project/nickmccurdy/karma-edge-launcher-ui7ax

I'll be sure to check out your new PR as this project has been kind of stagnant with the lack of edge-launcher updates. Thanks for your contribution!

Itee commented 5 years ago

@nickmccurdy You're welcome ! I just hope this will work, and go in the right way. I will take a look to appveyor.

jslegers commented 5 years ago

I didn't get either 0.4.2 or 0.4.3 to work as expected.

Version 0.4.2 closed Edge correctly, but open tabs were re-opened during the next run. This caused Edge to have X open tabs after X runs.

Version 0.4.3 failed to close Edge. And next run, Edge refused to start because it already was open.

I combined what worked in 0.4.2 with what worked in 0.4.3 and added some paths of this script, and now everything works as expected in my test environment.

With my changes, Edge now correctly starts with just one tab open every test run, and gets closed correctly afterwards.

For my changes, see https://github.com/karma-runner/karma-edge-launcher/pull/9