Switch macOS from `firefox-bin` to `firefox`

karma-runner / karma-firefox-launcher

A Karma plugin. Launcher for Firefox.

MIT License

104 stars 54 forks source link

Switch macOS from `firefox-bin` to `firefox` #330

Closed Krinkle closed 5 months ago

Krinkle commented 6 months ago

Upstream:

"firefox-bin is broken". https://bugzilla.mozilla.org/show_bug.cgi?id=1871447
"remove firefox-bin". https://bugzilla.mozilla.org/show_bug.cgi?id=1873782

Long story short:

Firefox has shipped both for a long time.
Firefox signs the binaries in a way that only firefox passes Apple's "hightened" security rules.
Firefox 121 adds support for Apple's Passkey feature and that raised the level of security rules it has to pass, thus making firefox-bin appear like an imposter. This means macOS terminates firefox-bin with the message Killed: 9.

Fixes https://github.com/karma-runner/karma-firefox-launcher/issues/328.

mgol commented 6 months ago

Given the following deprecation notice: https://github.com/karma-runner/karma-firefox-launcher/blob/a55a7f43fd8ecdce02fb9a558ed769381add8083/README.md#karma-firefox-launcher-is-deprecated-and-is-not-accepting-new-features-or-general-bug-fixes I am not sure if we'll get this fix merged. 😕 From the linked note:

Critical security issues in Karma will still be triaged and fixed as necessary.

Krinkle commented 5 months ago

@pmvald Thanks for merging this PR! Could you release this as well? Or are there other changes or steps we need to follow first? Let me know if I can help with anything.

pmvald commented 4 months ago

The release is automatic. This PR did not follow PR naming guidelines and so it did not trigger release for a new version by semver. I'll merge a bunch of other PRs which hopefully trigger a release.

karmarunnerbot commented 4 months ago

:tada: This PR is included in version 2.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: