search

karma-runner / karma-firefox-launcher

A Karma plugin. Launcher for Firefox.
MIT License
104 stars 53 forks source link

Can't start Firefox Nightly #80

Open konorlevich opened 6 years ago

konorlevich commented 6 years ago

OS: Ubuntu 17.10 Node: 8.9.3 npm: 5.6 @angular/cli: 1.6.1 Karma: 1.7.1 "karma-firefox-launcher": "~1.1.0"

firefox-trunk: Mozilla Firefox 59.0a1 was installed by following commands sudo add-apt-repository ppa:ubuntu-mozilla-daily/ppa sudo apt-get update sudo apt-get install firefox-trunk

>ng test

10% building modules 1/1 modules 0 active 16 12 2017 17:27:28.126:WARN [karma]: No captured browser, open http://localhost:9876/ 16 12 2017 17:27:28.132:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/ 16 12 2017 17:27:28.132:INFO [launcher]: Launching browser FirefoxNightly with unlimited concurrency 16 12 2017 17:27:28.137:INFO [launcher]: Starting browser FirefoxNightly
16 12 2017 17:27:31.051:WARN [karma]: No captured browser, open http://localhost:9876/

gluons commented 6 years ago

Same on Windows.

On Windows, it uses this:

https://github.com/karma-runner/karma-firefox-launcher/blob/cf20be3b93b3b0053a4f7f5b8e319758f846a914/index.js#L215

And

https://github.com/karma-runner/karma-firefox-launcher/blob/cf20be3b93b3b0053a4f7f5b8e319758f846a914/index.js#L57-L66

So the final path is C:\\Program Files\\Nightly\\firefox.exe. But I just install fresh Nightly on Windows 10. My Nightly located at C:\Program Files\Firefox Nightly\firefox.exe.

sasaxing commented 5 years ago

firefoxDirName seems not correct. On OSX FirefoxNightly is installed in a directory whose name has a space in between: Firefox Nightly.app. Not sure about windows, but it looks like the same issue.

birtles commented 5 years ago

I have a fix for this as part of https://github.com/birtles/karma-firefox-launcher/commit/da4e43b430193ed86d178cd78936c8985a967c77 but I'm currently trying to resolve #93 before putting any of that up for review.

birtles commented 5 years ago

This should now be fixed for Windows and Mac by 6377ee30adb122d0510da594e9b451574c1520f0 but I need to setup a Linux environment to check if firefox-trunk is still the binary name in more recent versions of Nightly.