karma-runner / karma-ie-launcher

A Karma plugin. Launcher for Internet Explorer.
MIT License
59 stars 23 forks source link

feat(web-server): run karma using multiple emulation modes #13

Closed sylvain-hamel closed 10 years ago

sylvain-hamel commented 10 years ago

Closes https://github.com/karma-runner/karma/issues/936, https://github.com/karma-runner/karma/issues/631

This is related to another pull request that I'm going to send to https://github.com/karma-runner/karma right after this one.

sylvain-hamel commented 10 years ago

I did not bump the version number in package.json. I don't know if that's my responsibility.

sylvain-hamel commented 10 years ago

Hi @vojtajina, do you need more information about this change before you can merge it? We rely on this fix and I'd like to see it merged soon. Thanks.

vojtajina commented 10 years ago

Awesome. You don't have to bump the package.json, that happens automatically during the release...

Can you please change the commit msg to feat: allow multiple IE versions in emulation modes or something? (you don't have to use the "" part in the plugins).

Otherwise this LGTM, merge it in!