search

karma-runner / karma-ie-launcher

A Karma plugin. Launcher for Internet Explorer.
MIT License
59 stars 23 forks source link

fix: kill all IE processes when terminating browser process #16

Closed sylvain-hamel closed 10 years ago

sylvain-hamel commented 10 years ago

closes #15

cthorne66 commented 10 years ago

I tested the updates, and still see one iexplorer.exe instance staying open in the background. When I end that last instance manually, my CI (Jenkins) finally confirms the results.

Without manually killing, it just hangs & waits.

This being said, there are no browsers visible during the issue, as they are closed from sight

sylvain-hamel commented 10 years ago

Does the iexplore.exe that stays there have command line args that look like this:

SCODEF:2632 CREDAT:275457 /prefetch:2

You can find this out by adding the command line column in Task Manager.

sylvain-hamel commented 10 years ago

In fact there are two fixes to fix this bug

  1. https://github.com/karma-runner/karma/pull/973 is the fix that is supposed to end IE correctly.
  2. This fix here is to end extra iexplor.exe processes that stay open.

Can you please try both fixes together and let me know.

cthorne66 commented 10 years ago

I'm seeing SCODEF:1300 CREDAT:78849 /prefetch:2. Forgot to mention I'm working with IE10 at the moment, but will have to apply the same to a IE11 instance. I will try both of those fixes & let you know. Thank you

cthorne66 commented 10 years ago

The confusion was on my end. Your changes are working to close the iexplor.exe, and therefor Jenkins is able to go on with it's work.

+1

Thank you very much!

sylvain-hamel commented 10 years ago

Awesome! Thanks for the update. I should be able to merge this PR this week.