search

karma-runner / karma-ie-launcher

A Karma plugin. Launcher for Internet Explorer.
MIT License
59 stars 23 forks source link

fix: fail when launcher is called if IE is not found #22

Closed sylvain-hamel closed 10 years ago

sylvain-hamel commented 10 years ago

instead of failing as soon as the plug-in is loaded closes #14

sylvain-hamel commented 10 years ago

There is no need to throw an exception. I think the result is better without it:

Before

WARN [plugin]: Error during loading "...sample\node_modules/karma-ie-launcher" plugin:
  Internet Explorer not found
INFO [karma]: Karma v0.12.1 server started at http://localhost:9876/
WARN [launcher]: Can not load "IE", it is not registered!
  Perhaps you are missing some plugin?
INFO [launcher]: Starting browser PhantomJS

Now

INFO [karma]: Karma v0.12.1 server started at http://localhost:9876/
INFO [launcher]: Starting browser IE
ERROR [launcher]: No binary for IE browser on your platform.
  Please, set "IE_BIN" env variable.
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Windows 8)]: Connected on socket WrcHBpB9BJCFUZTQ-DYi with id 
...

It is worth noting that It used to report the problem as a warning at loading time whereas now it reports it as error at run-time.