karma-runner / karma-ie-launcher

A Karma plugin. Launcher for Internet Explorer.
MIT License
59 stars 23 forks source link

chore: disable `-extoff` flag to be set by default #34

Closed v12 closed 9 years ago

v12 commented 9 years ago

Resolves #27

In many cases IE add-ons are essential for proper application functioning (i.e., parsing XML via MSXML), so explicitly setting -extoff flag makes impossible to run test suites for such apps.

If someone requires all add-ons to be switched off by the nature of the case (which is less likely but possible), it can be easily achieved by specifying that flag in customLaunchers section of Karma config though:

config.set({
  browsers: ['IE_no_addons'],
  // ...
  customLaunchers: {
    IE_no_addons: {
      base:  'IE',
      flags: ['-extoff']
    }
  }
});

Feel free to comment :wink:

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


dignifiedquire commented 9 years ago

Thanks, I agree that there should be a way to change this. Could you please add some documentation, so people know that this behaviour has changed and how to get it back please?

v12 commented 9 years ago

I've just added a section to the README that explains what was changed and how to deal with it.

Not sure about version number though. On the one hand, it is backward compatible change to the API because it won't break anything by running IE with add-ons enabled (they shouldn't have been used if everything worked), but, on the other hand, it can be considered as a bug fix. According to semver these changes require different version increment - minor for the first case and patch for the second. I made an assumption that it requires minor to be bumped. Correct me if I'm wrong :innocent:

dignifiedquire commented 9 years ago

It will be 0.2.0 as we haven't released a 1.0.0 yet, so we can make breaking changes in minor versions :)

dignifiedquire commented 9 years ago

LGTM

v12 commented 9 years ago

Just in case, I signed the CLA. :)

googlebot commented 9 years ago

CLAs look good, thanks!

v12 commented 9 years ago

Any updates on that? :)

murrayju commented 9 years ago

+1 Please merge this!

This totally prevents running tests that depend on ActiveX controls.

dignifiedquire commented 9 years ago

Thanks