search

karma-runner / karma-jasmine

A Karma plugin - adapter for Jasmine testing framework.
MIT License
542 stars 162 forks source link

chore: minor README.md tweaks #258

Closed XhmikosR closed 4 years ago

XhmikosR commented 4 years ago

I'm not familiar with conventional commit messages, so just let me know what to use

johnjbarton commented 4 years ago

the new husky/commitlint should be running so if they pass it should be ok. I just usually prefer the domain-scoped titles. kind(scope): what-changed.

XhmikosR commented 4 years ago

@johnjbarton one last thing: can you enable the delete HEAD branches in all karma repositories? Now the merged branches are left behind.

johnjbarton commented 4 years ago

done. What do you think about removing "Allow merge commits"?

On Mon, Jan 13, 2020 at 9:42 AM XhmikosR notifications@github.com wrote:

@johnjbarton https://github.com/johnjbarton one last thing: can you enable the delete HEAD branches in all karma repositories? Now the merged branches are left behind.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/karma-runner/karma-jasmine/pull/258?email_source=notifications&email_token=AABSGAQVF33QTCOZ4KD7ZQDQ5SRWZA5CNFSM4KGGBOTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZT2NI#issuecomment-573783349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSGASWCMZCPE22CAWOXSTQ5SRWZANCNFSM4KGGBOTA .

XhmikosR commented 4 years ago

Yeah, I don't use it either. Only squash and rebase, but it doesn't matter if you are consistent :)

karmarunnerbot commented 4 years ago

:tada: This PR is included in version 3.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: