Remove `Order.sort` function passing to Karma callback

[twolfson]

We received a bug report in karma-electron, https://github.com/twolfson/karma-electron/issues/47, which eventually traced back to Electron being unable to pass a function to between Karma contexts due to IPC fixing passing references between processes

This PR resolve that bug by removing the function which was being attempted to pass as a reference between processes

In this PR:

• Remove Order.sort function passing to Karma callback
• Fixes https://github.com/twolfson/karma-electron/issues/47

Feel free to request commit message changes (or apply them yourself). I tried to find documentation on them but was running out of time =/

[twolfson]

👍 Taking today off so will revisit tomorrow

On Tue, Aug 11, 2020, 9:35 AM johnjbarton notifications@github.com wrote:

@johnjbarton requested changes on this pull request.

The commit message first line would be like fix(adapter): filter functions from result

In src/adapter.js https://github.com/karma-runner/karma-jasmine/pull/272#discussion_r468712998 :

@@ -191,8 +191,13 @@ function KarmaReporter (tc, jasmineEnv) { // Any errors in top-level afterAll blocks are given here. handleGlobalErrors(result)

• // Remove functions from called back results to avoid IPC errors in Electron
• // https://github.com/twolfson/karma-electron/issues/47
• let cleanedOrder = Object.assign({}, result.order);

Looks like Object.assign() is not supported on IE11. https://caniuse.com/#search=object.assign

I think we could loop over Object.keys() and copy if typeof result[key] !== 'function'.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/karma-runner/karma-jasmine/pull/272#pullrequestreview-465237420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG4KWHDEBFRUYSZBLENBVLSAFXMFANCNFSM4O3G6YRQ .

[twolfson]

Oh wow, I somehow assumed this repo was using a transpiler somehow (usually avoid them myself). Going to also drop the let to avoid browser compatibility issues

[twolfson]

Also using getOwnPropertyNames as keys can iterate over prototype keys as well (which I believe we want to avoid)

[twolfson]

Alright, that should do it. Tested with repro repo here from original issue https://gist.github.com/twolfson/5122c4398147df6bb2bfaeb37a59997b

I'll update the commit message now with what you gave me

[twolfson]

Decided to just squash the commits as I don't know how the commits are merged/squashed on this repo =/

[karmarunnerbot]

:tada: This PR is included in version 4.0.1 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket:

[dpwatrous]

Thanks for keeping on top of this @twolfson and @johnjbarton thanks for getting this merged. I'll be glad to remove our kludgey workaround for this!