karma-runner / karma-jasmine

A Karma plugin - adapter for Jasmine testing framework.
MIT License
542 stars 163 forks source link

Update eslint-config-standard #315

Closed jginsburgn closed 2 years ago

jginsburgn commented 2 years ago

The newer eslint-config-standard versions have no-var set to warn so we are flooded with warnings. I suggest someone else deals with this later if/when the supported browsers change.

_Originally posted by @XhmikosR in https://github.com/karma-runner/karma-jasmine/pull/297#discussion_r848541305_

XhmikosR commented 2 years ago
jginsburgn commented 2 years ago

Can we not configure eslint's no-var rule to be supressed?

XhmikosR commented 2 years ago

Ah, true, my bad. I was under the impression we were using standard directly here, but I was obviously wrong. So, yeah, we can update to the latest version and adapt the rule.

karmarunnerbot commented 2 years ago

:tada: This issue has been resolved in version 5.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: