karma-runner / karma-mocha

A Karma plugin. Adapter for Mocha testing framework.
MIT License
379 stars 95 forks source link

Add support for full regexp --grep arguments #231

Open tux-rampage opened 4 years ago

tux-rampage commented 4 years ago

Motivation

Some IDEs (i.e. WebStorm) pass a full regexp, including the delimitters, to karma run (See WI-55539). This will cause the runner to skip all tests instead of applying the pattern.

This PR aims to provide compatibility for this behaviour.

Example

karma run --grep=/^some\\.test\\.Suite/
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

tux-rampage commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.