karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

Looking for qunit instead of qunitjs #101

Closed Johann-S closed 6 years ago

Johann-S commented 6 years ago

it's seems karma-qunit look for qunitjs but it should look for qunit

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
Johann-S commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

dignifiedquire commented 6 years ago

Thanks :octocat:

Johann-S commented 6 years ago

you're welcome 😉

Johann-S commented 6 years ago

@dignifiedquire I think there are still an issue 😟 now Karma find QUnit but tests failed immediatly, maybe they are some changes to do in the adapter 🤔

dignifiedquire commented 6 years ago

ugh, could you look into that and PR a test that runs a simple test using quint like we have in karma-mocha please?

On 14. Mar 2018, 16:00 +0100, Johann-S notifications@github.com, wrote:

@dignifiedquire I think there are still an issue 😟 now Karma find QUnit but tests failed immediatly, maybe they are some changes to do in the adapter 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Johann-S commented 6 years ago

I'll try to look at that later today