karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

fix (adapter): save and reset qunit-fixture properly #105

Closed asapach closed 6 years ago

asapach commented 6 years ago

As mentioned in #104, QUnit.begin() handler runs first for QUnit and then for karma-qunit adapter. QUnit saves any existing #qunit-fixture element as QUnit.config.fixture; if none exist at this point, #qunit-fixture will never be reset during QUnit.testStart(). karma-qunit runs too late to affect that, but it can create the missing #qunit-fixture element and save it as QUnit.config.fixture so that QUnit will pick it up.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
asapach commented 6 years ago

CLA signed.

googlebot commented 6 years ago

CLAs look good, thanks!

asapach commented 6 years ago

//CC @Krinkle

asapach commented 6 years ago

Sorry, messed up my local history. New PR here: #106