search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

fix (adapter): save and reset qunit-fixture properly #106

Closed asapach closed 6 years ago

asapach commented 6 years ago

As mentioned in #104, QUnit.begin() handler runs first for QUnit and then for karma-qunit adapter. QUnit saves any existing #qunit-fixture element as QUnit.config.fixture; if none exist at this point, #qunit-fixture will never be reset during QUnit.testStart(). karma-qunit runs too late to affect that, but it can create the missing #qunit-fixture element and set QUnit.config.fixture to an empty string (as documented) to be reset properly.

//CC @Krinkle

asapach commented 6 years ago

Could you please publish a new release?

Johann-S commented 6 years ago

I cannot publish to NPM I don't have the rights, maybe @johnjbarton can handle that 👍

dignifiedquire commented 6 years ago

published a new version from master

Johann-S commented 6 years ago

@dignifiedquire why did you the version number to v2.1.0 as it's just a bug fix ? 🤔 IMO v2.0.3 would be enough here

dignifiedquire commented 6 years ago

because I made a typo and realised it too late :( you are right, it should have been a patch version

asapach commented 6 years ago

Thanks for the release anyway :)

Johann-S commented 6 years ago

That's something happen 😄