search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

chore(packages): update dependencies #108

Closed Johann-S closed 5 years ago

Johann-S commented 6 years ago

Update dependencies

XhmikosR commented 6 years ago

Maybe something you updated drops node 4 support?

Also, I'm not sure they want package-lock.json here since they seem to be using yarn.

Johann-S commented 6 years ago

You're right about package-lock.json 👍 But it's more related to Travis because I merged a PR this afternoon and same error

XhmikosR commented 6 years ago

For example https://github.com/sindresorhus/load-grunt-tasks/blob/master/.travis.yml

johnjbarton commented 6 years ago

I sent a PR to drop node 4, then you can retry.

Johann-S commented 6 years ago

I'll update our packages again before merging this PR

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹī¸ Googlers: Go here for more info.

XhmikosR commented 5 years ago

All right, tests pass. We only need to solve the CLA thing @johnjbarton, then merge this, bump the minor version and release it.

XhmikosR commented 5 years ago

Does anybody know how we can proceed with the CLA?

googlebot commented 5 years ago

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

XhmikosR commented 5 years ago

I guess we are stuck then. We could drop this PR and I can make one PR with only my patch which should pass.

Johann-S commented 5 years ago

Seems good to me 👍