search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

feat(index): allow to use old qunitjs package #113

Closed Johann-S closed 5 years ago

Johann-S commented 6 years ago

I don't know what you think about that, but I think it's a good thing to allow people to use the old QUnit package if they want to.

/CC @XhmikosR @johnjbarton @dignifiedquire

XhmikosR commented 6 years ago

I don't think it makes any sense anymore. If one wants to use the old package they can stick to an old version.

Just my 2 cents.

Johann-S commented 6 years ago

that's true but they cannot benefits from some optimisation we made 🤔

Krinkle commented 5 years ago

@Johann-S Unfortunately, this is not only about package names. It is also implicitly about the version of those packages.

The added cost of maintaining and testing support of older versions of QUnit with the latest version of karma-qunit is too high in my opinion. There is also the matter of code complexity and ease-of-use. For example, how do we make sure that users still get useful peerDependencies warnings? And what if both packages are installed, which one is preferred?

The old version of karma-qunit should continue to work with the older version of qunit.

When users have the time/priority resources available to motivate an upgrade and benefit from the improvements we made, then karma-qunit and qunitjs should be upgraded together.

If you find there is a critical bug with old karma-qunit and old qunit together, please do report that. I am willing to consider reviving the old branch for a limited time to backport certain bug fixes and perform a minor release to improve and simplify the upgrade experience.

The QUnit team has also put great effort to make sure each version is backward- and forward compatible, which should make it possible to this without major changes in multiple places at the same time. For example. you can first update to the latest QUnit 1.x version, with has both the new and old APIs, then slowly update any tests to use the newer APIs , and then smoothly upgrade QUnit and karma-qunit together.