Closed vobu closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed the CLA
CLAs look good, thanks!
Any concers here @Krinkle, @johnjbarton or @XhmikosR ?
That line can be changed https://github.com/karma-runner/karma-qunit/pull/116/files#diff-e52a9a67956bd51d044af4058fb939ceR103
to :
log: testResult.errors,
sorry, missed this one in your original answer. updated now.
Hi guys,
any news on potentially merging this? Somewhat waiting for it as this would eliminate an error root cause in one of our projects.
Thx! -V.
hey, just wanted to check in with you guys @Johann-S et al to see how things are for this PR - would really like to use the updated code base. thx, v.
Thx for the merge! Could you guys please also bump and release the npm module?
I don't think I can do this myself, unfortunately.
I don't think I can do this myself, unfortunately.
then who has the power :) ? pinging @Johann-S and @dignifiedquire
Personally I'd like #108 merged before making a new release.
Fixes #115