karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

fix-115-array-error #116

Closed vobu closed 5 years ago

vobu commented 5 years ago

Fixes #115

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
vobu commented 5 years ago

I signed the CLA

googlebot commented 5 years ago

CLAs look good, thanks!

Johann-S commented 5 years ago

Any concers here @Krinkle, @johnjbarton or @XhmikosR ?

vobu commented 5 years ago

That line can be changed https://github.com/karma-runner/karma-qunit/pull/116/files#diff-e52a9a67956bd51d044af4058fb939ceR103

to :

log: testResult.errors,

sorry, missed this one in your original answer. updated now.

vobu commented 5 years ago

Hi guys,

any news on potentially merging this? Somewhat waiting for it as this would eliminate an error root cause in one of our projects.

Thx! -V.

vobu commented 5 years ago

hey, just wanted to check in with you guys @Johann-S et al to see how things are for this PR - would really like to use the updated code base. thx, v.

vobu commented 5 years ago

Thx for the merge! Could you guys please also bump and release the npm module?

XhmikosR commented 5 years ago

I don't think I can do this myself, unfortunately.

vobu commented 5 years ago

I don't think I can do this myself, unfortunately.

then who has the power :) ? pinging @Johann-S and @dignifiedquire

XhmikosR commented 5 years ago

Personally I'd like #108 merged before making a new release.