search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

Add karma in peerDependencies. #117

Closed XhmikosR closed 5 years ago

Johann-S commented 5 years ago

Since we don't support Node 6, I think we should bump Karma to v4

XhmikosR commented 5 years ago

I don't see this from the current .travis.yml.

Johann-S commented 5 years ago

You're right my bad 👍

XhmikosR commented 5 years ago

And also, I don't want to leave people who stick with karma 3.x out. Because that's what happened with karma 4.x. All 3.x users get the npm vulnerabilities.

So, my suggestion is https://github.com/karma-runner/karma-qunit/pull/108#issuecomment-478475898

After the minor release we can make a new major release dropping Node.js 6 later.