search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

Update karma to ^5.0.1 #138

Closed jdforrester closed 4 years ago

jdforrester commented 4 years ago

Fixes #137

XhmikosR commented 4 years ago

This has unrelated patches...

jdforrester commented 4 years ago

Happy to explicitly point out the CVEs you're leaving unpatched if that's the method prefered for this repo?

XhmikosR commented 4 years ago

Not leaving anything out. You should keep your PRs clean.

jdforrester commented 4 years ago

Not leaving anything out. You should keep your PRs clean.

OK, sure, manually-pointed PRs at each other works, but is horrible for you as a reviewer. I suppose we have to make-do.

XhmikosR commented 4 years ago

I just want things done, I don't have time to sugarcoat things, sorry.