Allow karma 5.x in peerDependencies

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.

MIT License

51 stars 38 forks source link

Closed XhmikosR closed 4 years ago

XhmikosR commented 4 years ago

@johnjbarton LGTY? Or should we just allow karma v5.0.0?

Fixes #137.

XhmikosR commented 4 years ago

I'll go with this patch since it seems everything works fine with karma 4.x too.

jdforrester commented 4 years ago

Karma 4 has known security vulnerabilities through minimist. See https://www.npmjs.com/advisories/1179.

johnjbarton commented 4 years ago

The 5x vs 4x is mostly about the minimal version of nodejs supported. You should be ok.