search

karma-runner / karma-qunit

A Karma plugin. Adapter for QUnit testing framework.
MIT License
51 stars 38 forks source link

feat: create a qunit-fixture element on test start #22

Closed marcins closed 9 years ago

marcins commented 9 years ago

As per the discussion is #18 - to match the default QUnit HTML runner, and allow for re-use of tests written for this runner with Karma, create a qunit-fixture div on test start, removing any existing div with this id if it exists.

dignifiedquire commented 9 years ago

LGTM

MatmaRex commented 9 years ago

Yes please. The fact that there is no #qunit-fixture when using Karma was quite annoying to discover. QUnit docs make it very clear that such element is always available.

When can I expect this to be released?

SimenB commented 9 years ago

Any chance of this getting merged? While the workaround in https://github.com/karma-runner/karma-qunit/issues/18#issuecomment-74264546 works, it'd be much cleaner if it just worked out of the box :smile:

@vojtajina

jvdl commented 9 years ago

+1 would like to see this merged as well. While adding the element manually works, doing it for hundreds of tests is not ideal.

dignifiedquire commented 9 years ago

Thanks for the reminder. I'm in the middle of going through all the karma repos and getting them up to speed. I'll tackle qunit in the next days.

SimenB commented 9 years ago

@Dignifiedquire Hey, any news here :smile:

dignifiedquire commented 9 years ago

Damn, there are just too many repos...

dignifiedquire commented 9 years ago

Thanks and sorry for the delay :octocat:

New release incoming soon

SimenB commented 9 years ago

Haha, I can understand that one. I'm just really happy things are happening in Karma again! :smile:

dignifiedquire commented 9 years ago

Published as 0.1.5 with a much cleaner code base and a readme in the package :)