search

karma-runner / karma-safari-launcher

A Karma plugin. Launcher for Safari.
MIT License
19 stars 15 forks source link

os dependency #2

Closed 4kochi closed 11 years ago

4kochi commented 11 years ago

We are using grunt and grunt-karma for our build process. The browser array is set dynamically in the Gruntfile, based on the installed browsers on the current system. Our team have Linux, Windows and Mac computers, so the code is tested in all browsers. This works fine with karma 0.8.

Now with the new version all browsers are plugins. But now we cannot add the karma-safari-launcher in the package.json as devDependency, since this will cause an error on windows an linux because this plugin need to be installed on darwin.

Is it possible to remove the os dependency so that we can have a package.json with all browser plugins? This issue is also true for the karma-ie-launcher.

Btw, Safari can also be installed on windows :smiley:

matanoc commented 11 years ago

i had the same problem

vojtajina commented 11 years ago

This makes sense. I think we should just remove these "os" restrictions from package.json.

4kochi commented 11 years ago

Great. Should i make a pull request? I could also add the default path for the Windows version of Safari.

vojtajina commented 11 years ago

@4kochi that'd be great, you can also add a safari path for windows...

4kochi commented 11 years ago

Done in c41053235ec67dff7656abd641d1a29291b02a4b