karma-runner / karma-safari-launcher

A Karma plugin. Launcher for Safari.
MIT License
19 stars 15 forks source link

Emits warning after shutdown #9

Open robertfmurdock opened 10 years ago

robertfmurdock commented 10 years ago

I just noticed a weird thing when I run karma with grunt as part of a larger build. After the karma task completes and moves on to subsequent grunt tasks, I sometimes get this message:

WARN [Safari 8.0.0 (Mac OS X 10.10)]: Disconnected (1 times), because no message in 10000 ms. Safari 8.0.0 (Mac OS X 10.10): Executed 24 of 48 DISCONNECTED (10.547 secs / 0.062 secs)

This is after karma-safari-launcher successfully shut down Safari and indicating that all the tests passed much earlier (about... drumroll please... ten seconds). It kind of looks like its somehow attempting a rerun, or accidentally starting two runs.

Since none of the other launchers have this problem, I figured I'd make a note of it here.

djforth commented 8 years ago

+1 Getting the same issue here:

Safari 9.0.3 (Mac OS X 10.11.3): Executed 13 of 28 DISCONNECTED (2.606 secs / 0.043 secs)
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 28 of 28 SUCCESS (0.125 secs / 0.188 secs)
Safari 9.0.3 (Mac OS X 10.11.3): Executed 28 of 28 SUCCESS (0.287 secs / 0.129 secs)
Chrome 48.0.2564 (Mac OS X 10.11.3): Executed 28 of 28 SUCCESS (0.1 secs / 0.053 secs)
Firefox 43.0.0 (Mac OS X 10.11.0): Executed 28 of 28 SUCCESS (0.05 secs / 0.048 secs)

npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/Cellar/node/5.4.0/bin/node" "/Users/adrianstainforth/.node_modules_global/bin/npm" "run" "test:mac"
npm ERR! node v5.4.0
npm ERR! npm  v3.7.1
npm ERR! code ELIFECYCLE
npm ERR! @djforth/morse-utils@1.0.4 test:mac: `asset-pipeline-karma -b`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @djforth/morse-utils@1.0.4 test:mac script 'asset-pipeline-karma -b'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the @djforth/morse-utils package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     asset-pipeline-karma -b
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs @djforth/morse-utils
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls @djforth/morse-utils
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/adrianstainforth/sites/modules/morse-utils/npm-debug.log

If I remove safari then I don't get the error. I'm guessing it's something with the safari running the test suite twice and disconnecting half way through one of the test runs?

jdmarshall commented 8 years ago

This is actually failing my builds, pretty consistently. Is there some new behavior here?

bmbarker90 commented 7 years ago

+1 seeing it as well, about 80% of the time

.
Safari 10.0.3 (Mac OS X 10.12.3): Executed 1 of 1 SUCCESS (0.001 secs / 0.009 secs)
.
Node.js (darwin; U; rv:v6.10.0) AppleWebKit/537.36 (KHTML, like Gecko): Executed 1 of 1 SUCCESS (0.019 secs / 0.01 secs)
.
Chrome 56.0.2924 (Mac OS X 10.12.3): Executed 1 of 1 SUCCESS (0.368 secs / 0.013 secs)
.
Firefox 50.0.0 (Mac OS X 10.12.0): Executed 1 of 1 SUCCESS (0.04 secs / 0.024 secs)
TOTAL: 4 SUCCESS
Safari 10.0.3 (Mac OS X 10.12.3) ERROR
  Disconnectedundefined
Safari 10.0.3 (Mac OS X 10.12.3): Executed 0 of 0 DISCONNECTED (2.562 secs / 0 secs)

Using: webpack 2.3.2 karma 1.5.0 karma-safari-launcher 1.0.0

jdmarshall commented 7 years ago

I still see this on average a couple times a week, which is much less than 80%, but way above the threshold of tolerable in a CI environment.

But the error messages @bmbarker90 is seeing is reminiscent of one I fixed for another karma launcher, and now I'm wondering if the cause is similar...