karma-runner / karma-sauce-launcher

A Karma plugin. Launch any browser on SauceLabs!
MIT License
199 stars 103 forks source link

Update package wd #149

Closed StabbarN closed 4 years ago

StabbarN commented 6 years ago

Update to include fix of https://github.com/admc/wd/issues/520 . See https://github.com/admc/wd/pull/522

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
jdmarshall commented 6 years ago

Looks like karma-sauce-launcher builds on Node 4, and wd 1.6 contains ES6 (does anybody in the node space actually read the semver spec??).

Are we specifically trying to maintain compatibility with Node 4 or would it be cool to bump travis up to node 6?

wswebcreation commented 4 years ago

@StabbarN

We are currently cleaning up the project and hope to get a new release out soon. Is still still valid (I think so) and if so can you rebase?

Grtz

@wswebcreation

StabbarN commented 4 years ago

I'm not using this project anymore so I'm unsure if it's valid and I can't verify if it still works. Anyway, wd 1.6.2 is probably outdated now :).

wswebcreation commented 4 years ago

Hi @StabbarN

Thanks for getting back, I'm going to close this PR for now and we will take a look at it when we are going to upgrade the dependencies.

Thanks