updated launcher to include heartbeat from Sauce

joshmgrant commented 5 years ago

Based on issue #159 I've taken a first shot at adding in the heartbeat functionality to keep alive a connection to Sauce.

Please let me know if you have any questions or if revisions are needed. Thanks!

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

joshmgrant commented 5 years ago

I signed it

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

rsimha commented 5 years ago

@vikerman Any chance this PR can be accepted? For context, we're using karma-sauce-launcher to run our integration tests for the AMP project (https://github.com/ampproject/amphtml), and have been running into long-standing issues around browser timeouts on Sauce Labs. We're hopeful that this fix will resolve them.

rsimha commented 5 years ago

Pinging a few recent committers for visibility: @devversion @dignifiedquire @johnjbarton

joshmgrant commented 4 years ago

Travis build is failing due to not being able to find environment variables.

vikerman commented 4 years ago

@johnjbarton - Can you take a look at this?

johnjbarton commented 4 years ago

The Travis CI fails with

Make sure the SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables are set.

wswebcreation commented 4 years ago

@johanneswuerbach and @joshmgrant

The variables can't be used because the PR is coming from a fork, not from a PR from this project, see also https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

@joshmgrant

Can you create a new PR based on this PR, but then as a branch from the project instead of a fork and then close this one? And for my understanding, this is just re-implementing the heartbeat we had in V1?

karma-runner / karma-sauce-launcher