search

karma-runner / karma-sauce-launcher

A Karma plugin. Launch any browser on SauceLabs!
MIT License
199 stars 103 forks source link

Add files field to package.json #194

Closed limonte closed 4 years ago

limonte commented 4 years ago

Fixes https://github.com/karma-runner/karma-sauce-launcher/issues/190#issuecomment-606169070

Docs: https://docs.npmjs.com/files/package.json#files

Files included with the “package.json#files” field cannot be excluded through .npmignore or .gitignore.

As a nice side-effect, no unnecessary files will be published and users' node_modules folder will be smaller.

image

limonte commented 4 years ago

The build is failing not because of this PR. Every PR will fail with the current Travis configuration, because env variables SAUCE_* aren't available for PR builds.

rcebulko commented 4 years ago

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

limonte commented 4 years ago

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

No, I can't because I don't have the write permission to this repo.

rcebulko commented 4 years ago

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

No, I can't because I don't have the write permission to this repo.

Okay, I'll just merge it; shouldn't have any impact on tests anyway

karmarunnerbot commented 4 years ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: