added null check - Githubissues

joshmgrant commented 4 years ago

Adding a null check for heartbeat functionality for Sauce Labs.

joshmgrant commented 4 years ago

Glad it worked :)

rcebulko commented 4 years ago

After merging, the build failed: https://travis-ci.org/github/karma-runner/karma-sauce-launcher/jobs/669798884?utm_medium=notification&utm_source=github_status

rcebulko commented 4 years ago

@joshmgrant It looks like some part of the heartbeat code might be trying to maintain the heartbeat even after the test session ends? Here's the relevant error message:

01 04 2020 17:18:43.969:ERROR [SaucelabsLauncher]: Could not quit the Saucelabs selenium connection. Failure message:
01 04 2020 17:18:43.969:ERROR [SaucelabsLauncher]: UnsupportedOperationError: ERROR The test with session id 17a4634414914e11adc0ff144a9c9160 has already finished, and can't receive further commands.
You can learn more at https://app.saucelabs.com/tests/17a4634414914e11adc0ff144a9c9160
For help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages
    at parseHttpResponse (/home/travis/build/karma-runner/karma-sauce-launcher/node_modules/selenium-webdriver/lib/http.js:557:11)
    at Executor.execute (/home/travis/build/karma-runner/karma-sauce-launcher/node_modules/selenium-webdriver/lib/http.js:468:26)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async WebDriver.execute (/home/travis/build/karma-runner/karma-sauce-launcher/node_modules/selenium-webdriver/lib/webdriver.js:696:17)
    at async Object.thenFinally [as finally] (/home/travis/build/karma-runner/karma-sauce-launcher/node_modules/selenium-webdriver/lib/promise.js:123:5)
    at async Promise.all (index 0) {
  name: 'UnsupportedOperationError',
  remoteStacktrace: ''
}

karmarunnerbot commented 4 years ago

:tada: This PR is included in version 4.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

karma-runner / karma-sauce-launcher

added null check #199