Closed jhildenbiddle closed 3 years ago
I got the same issue, last working version was 4.1.4
For Version 4.1.5 this change was made: https://github.com/karma-runner/karma-sauce-launcher/commit/7e75e171d695e07af2c4c2e207a5dc579abcfb4e?branch=7e75e171d695e07af2c4c2e207a5dc579abcfb4e&diff=split
It seems to me, that sauce:options is always passed to sauce labs with this change. According to sauce labs however, when sauce:options is passed, it always assumes that the new protocol W3C is used. However older browsers need to use the legacy JSONWP protocol instead.
Major dependency bump in a patch release is not that the users expect.
@rcebulko please consider reverting #207 on master and releasing 4.1.6
.
Then there should be 5.0.0
major release including saucelabs
bump.
Hi @web-padawan ,
Our project has moved away from Sauce Labs, and I am no longer actively involved on this repo. I briefly joined to try and fix some issues, but was unable to do so given the commits built up over a couple years without release. I believe I still have merge rights, so if you'd like to submit PR rolling by I'll approve it
Major dependency bump in a patch release is not that the users expect.
@web-padawan I don't see major dependency bumps problematic as long as they don't change the behavior of the software. In this case it actually did for people that still test on old browser that don't support the WebDriver protocol. I see two options:
sauce:option
capability only if provided capabilities suggest new browserv4.1.4
, make a new patch release, reapply changes and release as v5What would you all suggest?
Thank you for your feedback!
apply the sauce:option capability only if provided capabilities suggest new browser
Sounds goos to me in case if this would help to fix the errors with older browsers 👍
@web-padawan I don't see major dependency bumps problematic as long as they don't change the behavior of the software. In this case it actually did for people that still test on old browser that don't support the WebDriver protocol. I see two options:
- apply the
sauce:option
capability only if provided capabilities suggest new browser
This sounds like a great solution to me @christian-bromann !
@christian-bromann Sounds great!
New release that fixes this will come asap
:tada: This issue has been resolved in version 4.3.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Great to see this fixed. Thank you!
This is happening with multiple repos, all of which previously worked without issue.
Connections are made as expected when later versions of Chrome, Edge, Firefox, IE, and Safari are used (although with a deprecation warning as mentioned in #209). Easier versions of every browser fail consistently. For example, here is the console output from testing with Chrome 26 on Windows 10:
The error descriptions read to me like errors with karma-sauce-launcher:
I was able to come up with a list of browser/platform combinations that work reliably. Any browser version earlier than the ones listed below will fail to connect.
One thing I noticed on SauceLabs' Platform Configurator page is an option to select either the "WebDriver (W3C) - Selenium 3/4, Webdriver.io" or "Legacy - Selenium 2/3" API.
Perhaps the issue is related a configuration for the new API being incorrectly being sent to browser/platform combinations that are require the older API?
Thanks!