karma-runner / karma-sauce-launcher

A Karma plugin. Launch any browser on SauceLabs!
MIT License
199 stars 103 forks source link

undefined SaucelabsReporter adapters causes single-run=false to fail #217

Closed drzraf closed 3 years ago

drzraf commented 3 years ago

This is probably a follow-up of #87

With start --single-run=false, I'm getting:

16 09 2020 11:35:38.234:WARN [karma]: Error during refresh file list. TypeError: Cannot read property 'push' of undefined
    at _reporters.forEach (/x/node_modules/karma/lib/reporters/multi.js:11:61)
    at Array.forEach (<anonymous>)
    at MultiReporter.addAdapter (/x/node_modules/karma/lib/reporters/multi.js:11:21)
    at Server.<anonymous> (/x/node_modules/karma/lib/middleware/runner.js:97:18)
    at Object.onceWrapper (events.js:286:20)
    at Server.emit (events.js:203:15)
    at Server.EventEmitter.emit (domain.js:448:20)
    at Executor.schedule (/x/node_modules/karma/lib/executor.js:31:20)
    at refreshFileList.then (/x/node_modules/karma/lib/middleware/runner.js:42:18)

More specifically, within multi.js, during the loop, once it encounter the SaucelabsReporter and attempt to add an Adapter to the existing ones. But apparently, contrary to other reporters, this SaucelabsReporter contains no existing adapters (undefined) what provoke a failure when start --single-run=false is used with reporters: ['saucelabs']

Sounds like 9a5a147 fixed it but was lost at #156 (6525ddd4f) (@devversion )

karmarunnerbot commented 3 years ago

:tada: This issue has been resolved in version 4.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: