search

karma-runner / karma-sauce-launcher

A Karma plugin. Launch any browser on SauceLabs!
MIT License
199 stars 103 forks source link

Checking for the stored log never terminates if the network is down #269

Closed dcsaszar closed 2 years ago

dcsaszar commented 2 years ago

We just observed an endless log of lines like

[13:22:31] [2022-06-21T13:22:31.618] [INFO] SaucelabsLauncher - Check if 'log.json' for browser 'safari 14 ' has already been stored.

At this time Saucelabs tells us

Infrastructure Error -- The connection with your VM was lost and your job can't complete. You won't be charged for these minutes. For help, please check https://docs.saucelabs.com/dev/error-messages

Expected

The launcher terminates after some time

Actual

The launcher never terminates because of a retry logic mistake introduced in 3ef733b00f8713a6fa04aad53d96b0a6dbab06ac:

https://github.com/karma-runner/karma-sauce-launcher/blob/59b0c5c877448e064ad56449cd906743721c6b62/src/utils.ts#L12