search

karma-runner / karma-slimerjs-launcher

A Karma launcher for SlimerJS
MIT License
13 stars 19 forks source link

Depend on slimerjs #7

Closed megawac closed 9 years ago

megawac commented 10 years ago

Any reason this doesn't depend on slimerjs as the phantomjs launcher depends on phantomjs..? Its kind of annoying to have to tell people to run npm i -g slimerjs to run the unit tests

peterhughesdev commented 10 years ago

+1

The fact that it requires SlimerJS being installed as a global dependency is a no-go for me

aymericbeaumet commented 10 years ago

The reason why it differs from the PhantomJS launcher is because it has been implemented by a different developer. It has been migrated under the karma-runner org' so that we could take care of it.

I'm a little short in time by now. Yet if you want to contribute I would be glad to review your PR.

hashchange commented 9 years ago

@aymericbeaumet That's actually been fixed by #10 as well, can be closed. :)

aymericbeaumet commented 9 years ago

@hashchange Thanks :)