search

karma-runner / karma-slimerjs-launcher

A Karma launcher for SlimerJS
MIT License
13 stars 19 forks source link

Fails on Windows. Fix is available, please pull it #9

Closed hashchange closed 9 years ago

hashchange commented 9 years ago

I didn't get Karma to start SlimerJS on Windows, and I've spent a couple of hours grappling with the config. It was clear from the source, though, that this thing has never even once worked on Windows, given the DEFAULT_CMD setting.

As it turns out, PR #5 solves the problem right away. It's been sitting there for four months already, please pull it. Thanks!

aymericbeaumet commented 9 years ago

I would be glad to merge this PR once it follows the Karma norm.

You can propose a new PR if you think it's going to take some time before @bessdsv answers.

hashchange commented 9 years ago

Just did it: #10. It's a reworked version of the PR by @bessdsv. I have reviewed and cleaned up the code, and tested it (briefly) on all platforms. The details are in the commit message.

Thanks, by the way, for your quick response!

aymericbeaumet commented 9 years ago

Thanks @hashchange, merged! :+1: