karma-runner / karma-teamcity-reporter

A Karma plugin. Report results for Teamcity CI.
MIT License
34 stars 47 forks source link

fix: Remove fs.writeSync as default adapter and add TeamCity setup do… #83

Closed kevcenteno closed 6 years ago

kevcenteno commented 7 years ago

…cumentation

Closes #38

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


kevcenteno commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

kevcenteno commented 7 years ago

Unrelated build failure: Failure due to npm no longer supporting node v0.10. Maybe the CI build should remove this test.

kevcenteno commented 7 years ago

Might also fix #25

kevcenteno commented 7 years ago

@dignifiedquire Any thoughts on this?

dizel3d commented 6 years ago

@kevcenteno, it works, thank you!

Generally, the PR just reverted the fix https://github.com/karma-runner/karma-teamcity-reporter/commit/d8d9e70630031de66036d81b396561fb6de20f70, which isn't actual anymore. (https://github.com/karma-runner/karma-teamcity-reporter/issues/32#issuecomment-197908787 explains why.) So I look forward to merging.

@dignifiedquire, ping.

dizel3d commented 6 years ago

@kevcenteno, rebase your PR to actual master, please, to fix Travis CI build.

kevcenteno commented 6 years ago

Rebased

kevcenteno commented 6 years ago

@dignifiedquire @dizel3d Tests are passing and ready for merge

dignifiedquire commented 6 years ago

Thank you :octocat: