Closed kevcenteno closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Unrelated build failure: Failure due to npm no longer supporting node v0.10. Maybe the CI build should remove this test.
Might also fix #25
@dignifiedquire Any thoughts on this?
@kevcenteno, it works, thank you!
Generally, the PR just reverted the fix https://github.com/karma-runner/karma-teamcity-reporter/commit/d8d9e70630031de66036d81b396561fb6de20f70, which isn't actual anymore. (https://github.com/karma-runner/karma-teamcity-reporter/issues/32#issuecomment-197908787 explains why.) So I look forward to merging.
@dignifiedquire, ping.
@kevcenteno, rebase your PR to actual master
, please, to fix Travis CI build.
Rebased
@dignifiedquire @dizel3d Tests are passing and ready for merge
Thank you :octocat:
…cumentation
Closes #38