search

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

Allow passing more props #11

Closed drkibitz closed 10 years ago

drkibitz commented 10 years ago

Fix for https://github.com/karma-runner/karma-webdriver-launcher/issues/4

This was my fix to allow other properties for ios-driver/appium nodes. If this isn't the ideal fix, another solution would to simply have another property on args object called caps, capabilities, or extra. But this would get confusing IMO.

aparkinson commented 10 years ago

Thank you for your contribution!

I have been away recently but I will get round to looking at it very soon.

arikon commented 10 years ago

@aparkinson Could you review this and merge, please?

deepsweet commented 10 years ago

+1 here, could it be merged?

drkibitz commented 10 years ago

Since this pull request has been sitting for 8 months, I'm feeling like it's not worth contributing to this repository and probably won't fix anything on this pull request.

deepsweet commented 10 years ago

@vojtajina hi. sorry for disturbing you with this issue, but it seems like we need to maintain a custom fork with all the necessary PR applied. is there a chance to see some movements in this repository? thanks :)

arikon commented 10 years ago

@vojtajina Could you pass maintainer rights to someone else, please?

mtscout6 commented 10 years ago

+1 To this pull request and if necessary adding additional maintainers, with corresponding push rights to npm.

mtscout6 commented 10 years ago

Can we please get a collaborator working on this?

maksimr commented 10 years ago

@drkibitz Thanks for PR and sorry for long reply! We all very busy

Please change commit message following git commit message convention

mtscout6 commented 9 years ago

Pushed with version 0.3.0