karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

Use kill event instead overriding the .kill() #12

Closed persidskiy closed 10 years ago

persidskiy commented 10 years ago

Hi, After Karma#11.11 (e6f36ca) the .kill() metdod of launcher must return promise, otherwise the attempt to kill browser crashes on this step with

TypeError: Cannot call method 'then' of undefined

We can use asyc kill-event to kill the browser instead of overriding .kill() method.

iknite commented 10 years ago

We are dealing with the same just now, and the fix works like a charm, kudos @Coltspb you same me a headache!

arikon commented 10 years ago

:+1:

aparkinson commented 10 years ago

Thanks you for the Pull Request