Fix: correct methods overriding

[j0tunn]

Current implementation replaces ProcessLauncher._start method, but instead of replacing any method dealing with kill it just adds new listener for kill event which just calls callback. As a result:

• BaseLauncher._done method never called and so no event done emitted and karma process hangs
• callback called twice:
  • first time from ProcessLauncher's kill listener without any error
  • second time from WebDriverInstance's kill listener
• nobody removes tmp dir created by ProcessLauncher's start listener

To fix this we shouldn't add any new listener but override any methods called from ProcessLauncher's start/kill listeners:

• _start
• _process.kill
• _onKillTimeout

[j0tunn]

@aparkinson take a look at this PR please

[j0tunn]

@mtscout6 thanks man. When we should expect new version?

[mtscout6]

I'm still working on push rights to npm, as soon as that's in order I'll push out an update.

On Fri, Nov 14, 2014, 22:24 j0tunn notifications@github.com wrote:

@mtscout6 https://github.com/mtscout6 thanks man. When we should expect new version?

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/15#issuecomment-63161369 .

[mtscout6]

Pushed with version 0.3.0