Imitate some activity to avoid disconnect from selenium by timeout

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.

MIT License

66 stars 40 forks source link

Imitate some activity to avoid disconnect from selenium by timeout #21

Closed j0tunn closed 9 years ago

j0tunn commented 9 years ago

In case of large amount of tests (800+) and slow browser (ie8) tests can run for a relatively long time (70-80 seconds). There is no activity until tests finish, and Selenium kills session by timeout (60 seconds by default). This patch just periodically requests page title thus imitating activity.

j0tunn commented 9 years ago

@mtscout6 Take a look at this PR, please

mtscout6 commented 9 years ago

Is there a reason you wouldn't just increase the karma and or selenium timeout configuration values?

j0tunn commented 9 years ago

There are few reasons actually:

it wouldn't fix the problem completely (or it must be huge timeout)
timeout is a tool to close actually inactive browsers
this timeout can be set only on hub or on node, not in karma. And I just don't have access to those machines

j0tunn commented 9 years ago

@mtscout6 ping

mtscout6 commented 9 years ago

LGTM

Need one additional set of eyes from @karma-runner/owners.

j0tunn commented 9 years ago

@aparkinson @vojtajina take a look please

j0tunn commented 9 years ago

@zzo done

j0tunn commented 9 years ago

@zzo Thanks. When should we expect version?

zzo commented 9 years ago

working on that now - so soon! thanks

On Thu, May 7, 2015 at 6:29 AM, j0tunn notifications@github.com wrote:

@zzo https://github.com/zzo Thanks. When should we expect version?

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/21#issuecomment-99866165 .

mtscout6 commented 9 years ago

@zzo I can push that real quick. I'll also add you as one of it's owners on npm.

zzo commented 9 years ago

yes please do - just found out I don't have auth thanks! Mark

On Thu, May 7, 2015 at 6:31 AM, Matt Smith notifications@github.com wrote:

@zzo https://github.com/zzo I can push that real quick. I'll also add you as one of it's owners on npm.

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/21#issuecomment-99866757 .

zzo commented 9 years ago

I should add the version number has already been updated - you just need to npm publish thx!

On Thu, May 7, 2015 at 6:31 AM, Mark Ethan Trostler mark@zzo.com wrote:

yes please do - just found out I don't have auth thanks! Mark

On Thu, May 7, 2015 at 6:31 AM, Matt Smith notifications@github.com wrote:

@zzo https://github.com/zzo I can push that real quick. I'll also add you as one of it's owners on npm.

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/21#issuecomment-99866757 .

mtscout6 commented 9 years ago

No problem this is you right? https://www.npmjs.com/~zzo

mtscout6 commented 9 years ago

I'm pretty sure it's you, only karma packages. You need an avatar :wink:

zzo commented 9 years ago

yes that's me. ya need a cool one.

On Thu, May 7, 2015 at 6:34 AM, Matt Smith notifications@github.com wrote:

I'm pretty sure it's you, only karma packages. You need an avatar [image: :wink:]

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/21#issuecomment-99867476 .

mtscout6 commented 9 years ago

K, you're added and I published the package.

zzo commented 9 years ago

thank you

On Thu, May 7, 2015 at 6:36 AM, Matt Smith notifications@github.com wrote:

K, you're added and I published the package.

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/21#issuecomment-99867779 .