search

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

wd version up #22

Closed j0tunn closed 9 years ago

j0tunn commented 9 years ago

There were a lot of fixes + better appium/selendroid support since wd@2.8: https://github.com/admc/wd/blob/master/doc/release-notes.md

j0tunn commented 9 years ago

@mtscout6 @zzo what do you think?

mtscout6 commented 9 years ago

LGTM

zzo commented 9 years ago

has this been run thru the karma integration tests? Otherwise lgtm. And while you're mucking around in package.json can you also remove the deprecated 'peerDependency' block? thx!

j0tunn commented 9 years ago

has this been run thru the karma integration tests?

I tried this on my project with my tests: everything is ok. Or you are talking about some sort of special-karma-test I don't know about?

zzo commented 9 years ago

ha I was talking about https://github.com/karma-runner/integration-tests but now I see there's not one for webdriver which is sad. OK lgtm thx

zzo commented 9 years ago

this is now on npm as 1.0.3

j0tunn commented 9 years ago

thanks!