karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

add remote host features #23

Closed johnny-mh closed 8 years ago

johnny-mh commented 9 years ago

change url in launcher to remote test execution.

it can be applied desktop, mobile, etc...

it already use for my company.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


johnny-mh commented 9 years ago

I signed it!

googlebot commented 9 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

zzo commented 9 years ago

can you rebase please thanks!

johnny-mh commented 8 years ago

I signed it!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

minhyeong-kim commented 8 years ago

I signed it!

johnny-mh commented 8 years ago

@zzo Sorry to late reply. I rebase branch. but CLA check are hard to make it success.

"everedifice", "minhyeong-kim" are me. how do i to make CLA check success?

johnny-mh commented 8 years ago

I pull request later.