search

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

fix: kill() is waiting forever when a browser is failed to obtain #24

Closed scf2k closed 9 years ago

scf2k commented 9 years ago

Changed quit() to be called on the object retrived via wd.remote() instead of the object which is returned by the methods chain. This fixes the cases when a browser is failed to obtain and launcher stuck at killing it.

j0tunn commented 9 years ago

LGTM. @zzo @mtscout6 take a look, please

zzo commented 9 years ago

lgtm but what is going on w/travis - why does it think this is a ruby project?

scf2k commented 9 years ago

I have no idea, but this happened with my pull request to karma-junit-repoter :)

mtscout6 commented 9 years ago

I'm out of town until next Monday. I can look at it then.

On Thu, Jul 9, 2015, 08:33 Vladimir Alaev notifications@github.com wrote:

I have no idea, but this happened with my pull request to karma-junit-repoter :)

— Reply to this email directly or view it on GitHub https://github.com/karma-runner/karma-webdriver-launcher/pull/24#issuecomment-120003085 .

scf2k commented 9 years ago

@mtscout6 had a chance to take a look?

mtscout6 commented 9 years ago

Aside from the variable naming everything looks good.

scf2k commented 9 years ago

@mtscout6 done

mtscout6 commented 9 years ago

LGTM, the travis ci is failing though I'd expect it to with the current configuration on the master branch. See #25 for a minor step in a better direction. @zzo once this is merged do you have this wired up with any particular release process?

zzo commented 9 years ago

Thanks I merged your .travis.yml stuff - for some reason travis thinks this is a ruby project. This packages uses the same release process as all of the other plugins which is pretty bare bones. Ideally this process would be managed via the mary poppins process like the main karma package but we are not there yet. FWIW the release process is simply 'grunt release' which bumps the version number and publishes to npm

zzo commented 9 years ago

v1.0.4 released on npm