updated wd dependency - Githubissues

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.

MIT License

66 stars 40 forks source link

updated wd dependency #35

Closed donaldpipowitch closed 7 years ago

donaldpipowitch commented 7 years ago

Seems to work fine in my projects (e.g. tested with @mercateo/ws).

This will update wd and we will get rid of npm warnings (especially when https://github.com/admc/wd/pull/457 is merged and released).

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

donaldpipowitch commented 7 years ago

Reviewer request: @zzo, because of this pull request https://github.com/karma-runner/karma-webdriver-launcher/pull/22.

zzo commented 7 years ago

so what's going on w/the travis failures - is it related to this?

donaldpipowitch commented 7 years ago

I don't know. Looks more like problems with grunt dependencies...?

zzo commented 7 years ago

I updated those grunt task versions can you please rebase your pr against master and try again? thanks!!

donaldpipowitch commented 7 years ago

Not sure if this worked...? 🤔

zzo commented 7 years ago

ha ya it 'worked' there just aren't any tests :)

zzo commented 7 years ago

published to npm at 1.0.5 thanks!