search

karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

Add useful context to WebDriver errors #39

Closed joeyparrish closed 5 years ago

joeyparrish commented 5 years ago

With the "Promise-based" API from "wd", you can't actually handle rejections. You can intercept them with .then(), but they still register as "unhandled rejections" in Karma, and the error messages are devoid of useful context.

This change uses the older callback-based model of "wd" instead, so that we can make sure the error log contains enough context to pin down issues to the specific Selenium node that failed.

Closes #38

joeyparrish commented 5 years ago

Overall I would encourage you to get rid of ‘wd’. Selenium has a native node client (4.0.0a) or the webdriver.io package.

Understood. I'll file a new issue and consider that for the future. Thanks!