karma-runner / karma-webdriver-launcher

A plugin for Karma. Launch any browser with WebDriver.
MIT License
66 stars 40 forks source link

Default conf doesn't work with Karma version: 0.10.2 #5

Closed koola closed 9 years ago

koola commented 11 years ago

As title. The only way this would run on my setup was to change line 31 in index,js as follows;

self.browser = wd.remote(config.hostname, config.port);

As per the wd docs, using either a url string or named params failed to initialize the webdriver, but using index params just worked.

emanuil commented 10 years ago

just created a pull request to fix this

@koola thanks for the workaround.

@aparkinson please approve.

aparkinson commented 10 years ago

@koola That change will work but not flexible for all the possible WebDriver configurations (e.g. username and password). The config you pass to the launcher should use hostname instead of url, the readme has been corrected for this.

mtscout6 commented 9 years ago

@koola Did @aparkinson's solution work for you? Are you ok with closing this issue?