fix: set socket.io closeOnBeforeunload option to true

karma-runner / karma

Spectacular Test Runner for JavaScript

http://karma-runner.github.io

MIT License

11.93k stars 1.71k forks source link

fix: set socket.io closeOnBeforeunload option to true #3853

Open fagia opened 11 months ago

fagia commented 11 months ago

Since this change on socket.io-client: https://github.com/socketio/engine.io-client/commit/a63066bdc8ae9e6746c3113d06c2ead78f4a4851, the default value for closeOnBeforeunload option is now "false".

On Karma.js side, this can lead to error message: "Some of your tests did a full page reload!".

In order to keep the previous behaviour, this commit explicitly sets the closeOnBeforeunload option to "true".

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.