search

karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.
Apache License 2.0
45 stars 26 forks source link

Fixed problem with browser list. #25

Closed sajanchandran closed 10 years ago

sajanchandran commented 10 years ago

Original problem if we put spaces after comma in the browser list the plugin is not generating the karma command correctly. e.g in configuration if we do 

<browsers>PhantomJS, Chrome</browsers>

The plugin is not generating the karma process command correctly, and because of that the test on Chrome browser is not getting executed and all we see is just a warning. The code fix check for spaces after the comma in the browsers list and appropriately construct the correct browser list.

kelveden commented 10 years ago

Thanks for pr @sajanchandran. Will try and get a release up to Maven Central soon.