search

karma-runner / maven-karma-plugin

Maven plugin for running tests using Karma.
Apache License 2.0
45 stars 26 forks source link

Making karma executable configurable #5

Closed dtabuenc closed 11 years ago

dtabuenc commented 11 years ago

I think the karma executable should be configurable for instances where the default won't work. For example, in windows, the executable needs to be named karma.cmd in order for it to work. This adds a node to the configuration for configuring that, leaving "karma" as the default.

vojtajina commented 11 years ago

@kelveden any update on this ?

kelveden commented 11 years ago

This will be solved with the pull request for #6 I think. Sound fair enough @dtabuenc? I'll get that pull request up to Maven Central in the next few days - once it's there try it out and see if it solves your issue.

kelveden commented 11 years ago

Version 1.1 of the plugin is now up in Maven Central. If it doesn't solve your issue feel free to re-open and I'll take a closer look.