search

karmada-io / dashboard

Web UI for Karmada
Apache License 2.0
49 stars 42 forks source link

fix: correct translation string usage and JSX formatting in Popup confirm #71

Closed axif0 closed 19 hours ago

axif0 commented 3 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: The translation and string concatenation in the Popconfirm component to ensure proper rendering of the confirmation message and handling of translations.

Which issue(s) this PR fixes: Fixes # N/A

Special notes for your reviewer: N/A

Does this PR introduce a user-facing change?: N/A

Signed-off-by: axif muhamadasif570@gmail.com

karmada-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign warjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/dashboard/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
warjiang commented 3 months ago

Thanks for your translation, it's useful, but now we're developing a i18n cli tools for automatically translating, but now the cli in the status of WIP cc @chouchongYHMing, it will works in the mode of hybird including manual mode and auto mode, some of your translation is useful, but some are not we expected, like image we expected this kind of translation like ${i18nInstance.t('xxx', r.objectMeta.name)} and the map for xxx will be like 集群%1删除成功 for cn and Cluster%1delete successfully for en. I think we can pend this pr, and renew it when the i18n-cli has any update

warjiang commented 1 month ago

/assign

RainbowMango commented 3 weeks ago

@axif0 The conflicts should be resolved before moving forward.

warjiang commented 3 weeks ago

@axif0 can you rebase the code, it seems that we can move forward

warjiang commented 2 weeks ago

@axif0 There are some conflict with the main branch, can you resolve the conflict, and recheck the PR ?

axif0 commented 2 weeks ago

Hello, as this pr a bit too old for target branch. And I see we already fixed i18n tools. Should I close the PR?