Closed chouchongYHMing closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign warjiang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Adding label
do-not-merge/contains-merge-commits
because PR contains merge commits, which are not allowed in this repository. Usegit rebase
to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@chouchongYHMing You need to rebase the main branch before submit the PR
/retitle [Summer OSPP 2024] Karmada Dashboard Automation i18n Tool
@chouchongYHMing the yarn.lock
is not necessary, we only choose pnpm in dashboard project, it can work well with monorepo
and we should split the proposal and the implementation, one PR only for proposal, the next one only for implementation
/assign
What type of PR is this? feature
What this PR does / why we need it: This is the auto i18n-tool
Which issue(s) this PR fixes: Fixes #53
Special notes for your reviewer: It's for ospp project.
Does this PR introduce a user-facing change?: No, It's just for developer.