karmada-io / dashboard

Web UI for Karmada
Apache License 2.0
49 stars 42 forks source link

[Summer OSPP 2024] The proposal update of Karmada Dashboard Automation i18n Tool #94

Closed chouchongYHMing closed 1 month ago

chouchongYHMing commented 2 months ago

What type of PR is this? feature

What this PR does / why we need it: This is the auto i18n-tool

Which issue(s) this PR fixes: Fixes #53

Special notes for your reviewer: It's for ospp project.

Does this PR introduce a user-facing change?: No, It's just for developer.

karmada-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign warjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/dashboard/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
warjiang commented 2 months ago

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chouchongYHMing You need to rebase the main branch before submit the PR

warjiang commented 2 months ago

/retitle [Summer OSPP 2024] Karmada Dashboard Automation i18n Tool

warjiang commented 2 months ago

@chouchongYHMing the yarn.lock is not necessary, we only choose pnpm in dashboard project, it can work well with monorepo

warjiang commented 2 months ago

and we should split the proposal and the implementation, one PR only for proposal, the next one only for implementation

warjiang commented 2 months ago

/assign